Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed duplicated config section in composer.json #51

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Removed duplicated config section in composer.json #51

merged 2 commits into from
Oct 3, 2023

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Sep 20, 2023 •
edited
Loading

Question Answer
JIRA issue -
Type bug
Target Ibexa version v4.5
BC breaks no

Plugins are already disallowed in https://github.com/ibexa/solr/blob/main/composer.json#L72-L76.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping for example @ibexa/php-dev for back-end changes and/or @ibexa/javascript-dev for front-end changes).

@adamwojs adamwojs requested a review from a team September 20, 2023 04:34
konradoboza
konradoboza reviewed Sep 20, 2023
View reviewed changes
Copy link
Contributor

@konradoboza konradoboza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be consistent, I would go with removing the first occurrence and sticking to:

"config": {
    "allow-plugins": false
}

@konradoboza konradoboza requested a review from a team September 20, 2023 06:20
@adamwojs
Copy link
Member Author

adamwojs commented Oct 2, 2023

FYI: phpstan issues fixed in #53

@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@adamwojs adamwojs merged commit f731b4c into 4.5 Oct 3, 2023
19 checks passed
@adamwojs adamwojs deleted the adamwojs-patch-1 branch October 3, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@webhdx webhdx webhdx approved these changes

@alongosz alongosz alongosz approved these changes

@Nattfarinn Nattfarinn Nattfarinn approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

Assignees

@Steveb-p Steveb-p

@alongosz alongosz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@adamwojs @Steveb-p @Nattfarinn @alongosz @webhdx @konradoboza