Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[All] Added app-switcher and headless-assets bundles #115

Merged
merged 1 commit into from
May 10, 2024

Conversation

dew326
Copy link
Contributor

@dew326 dew326 commented Apr 3, 2024

🎫 Issue IBX-7949

Description:

For QA:

Documentation:

@dew326 dew326 requested a review from webhdx April 3, 2024 10:35
@dew326 dew326 self-assigned this Apr 3, 2024
Copy link

github-actions bot commented Apr 3, 2024

Thanks for contribution! 🎉

To test the changes please execute:

composer config extra.symfony.endpoint https://api.github.com/repos/ibexa/recipes-dev/contents/index.json?ref=flex/pull-115

before executing the recipes.

Copy link

sonarcloud bot commented Apr 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

"bazinga:js-translation:dump %PUBLIC_DIR%/assets --merge-domains": "symfony-cmd",
"ibexa:encore:compile": "symfony-cmd"
}
"aliases": ["ibexa-commerce", "dxp-commerce", "cms-commerce", "commerce"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intentional reformatting ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation definitely, we want to change from 2spaces to 4spaces.
I'm not sure if breaking arrays will suit everyone and this is open for discussion.

@dew326 dew326 merged commit e2314fb into master May 10, 2024
3 checks passed
@dew326 dew326 deleted the add-app-switcher branch May 10, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants