Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-7611: Bump version for webpack and sass-loader #108

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

lucasOsti
Copy link
Contributor

@lucasOsti lucasOsti commented Jan 24, 2024

Jira ref: https://issues.ibexa.co/browse/IBX-7611

Bump version for

  • @symfony/webpack-encore ^1.7.0 -> ^3.0.0
  • sass-loader ^12.5.0 -> ^13.0.0

Copy link

Thanks for contribution! 🎉

To test the changes please execute:

composer config extra.symfony.endpoint https://api.github.com/repos/ibexa/recipes-dev/contents/index.json?ref=flex/pull-108

before executing the recipes.

@lucasOsti lucasOsti force-pushed the IBX-7611-pld-vulnerable-postcss branch from 8f28981 to 8cef2ef Compare January 30, 2024 15:34
@lucasOsti lucasOsti requested a review from dew326 January 30, 2024 15:35
@@ -2,7 +2,7 @@
"devDependencies": {
"@hotwired/stimulus": "^3.0.0",
"@symfony/stimulus-bridge": "^3.0.0",
"@symfony/webpack-encore": "^1.7.0",
"@symfony/webpack-encore": "^3.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing sass-loader change

Copy link

sonarcloud bot commented Jan 31, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@lucasOsti lucasOsti requested a review from dew326 January 31, 2024 08:44
@glye
Copy link

glye commented Jan 31, 2024

@lucasOsti Ready for QA?

Copy link

@glye glye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh BTW I just noticed the target is master, this should go into 4.5

@lucasOsti
Copy link
Contributor Author

Here we only have branch master but in this PR I edited files for version 4.5 e.g https://github.com/ibexa/recipes-dev/pull/108/files#diff-b602eecefcd395939d9c80eec7bc0f8a40fbc0d53a52537e12d7e81415dff1baL2

Copy link

@glye glye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh 😅

Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installed and tested on 4 editions of 4.5 and 4.6.

@micszo micszo removed their assignment Feb 21, 2024
@Nattfarinn Nattfarinn merged commit bc4c912 into master Feb 22, 2024
2 checks passed
@Nattfarinn Nattfarinn deleted the IBX-7611-pld-vulnerable-postcss branch February 22, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants