-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-7611: Bump version for webpack and sass-loader #108
Conversation
Thanks for contribution! 🎉 To test the changes please execute:
before executing the recipes. |
8f28981
to
8cef2ef
Compare
@@ -2,7 +2,7 @@ | |||
"devDependencies": { | |||
"@hotwired/stimulus": "^3.0.0", | |||
"@symfony/stimulus-bridge": "^3.0.0", | |||
"@symfony/webpack-encore": "^1.7.0", | |||
"@symfony/webpack-encore": "^3.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing sass-loader change
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
@lucasOsti Ready for QA? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh BTW I just noticed the target is master, this should go into 4.5
Here we only have branch master but in this PR I edited files for version 4.5 e.g https://github.com/ibexa/recipes-dev/pull/108/files#diff-b602eecefcd395939d9c80eec7bc0f8a40fbc0d53a52537e12d7e81415dff1baL2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
D'oh 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installed and tested on 4 editions of 4.5 and 4.6.
Jira ref: https://issues.ibexa.co/browse/IBX-7611
Bump version for