Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in setBlock/wrapBlock behavior #674

Closed
oyeanuj opened this issue Mar 22, 2017 · 3 comments
Closed

Inconsistency in setBlock/wrapBlock behavior #674

oyeanuj opened this issue Mar 22, 2017 · 3 comments

Comments

@oyeanuj
Copy link
Contributor

oyeanuj commented Mar 22, 2017

I came across a case where setBlock followed by wrapBlock works differently when done at the beginning of the doc and when done someplace else.

Here is a simple JSFiddle illustrating that - https://jsfiddle.net/u2r1e2wm/1/

I am not sure if I'm misunderstanding the behavior or missing some detail here, but wanted to bring it up since nothing else was apparent to me.

@ianstormtaylor
Copy link
Owner

This issue hasn't had a response in a while, and it's unclear if it's still present in the latest versions of Slate. To keep the issues easier to manage, since there are so many being opened every day, I'm going to close this old one out.

But if you notice that the bug is still happening, please feel free to comment and it can be revisited. It might be an edge case that not many people run into, in which case the fastest way to get it fixed would probably be to write a pull request for it.

Thanks for understanding!

@oyeanuj
Copy link
Contributor Author

oyeanuj commented Aug 1, 2017

@ianstormtaylor This is still occurring in the latest version of Slate. Here is an updated JSFiddle - https://jsfiddle.net/u2r1e2wm/2/

My guess is that the problem is somewhere in the code for wrapBlock - maybe you have other insights into what might be going on?

@ianstormtaylor ianstormtaylor reopened this Aug 1, 2017
@ianstormtaylor ianstormtaylor mentioned this issue Nov 6, 2019
@ianstormtaylor
Copy link
Owner

Fixed by #3093.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants