Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert AfterPlugin to use paths #2022

Closed
5 tasks
ianstormtaylor opened this issue Aug 1, 2018 · 1 comment
Closed
5 tasks

convert AfterPlugin to use paths #2022

ianstormtaylor opened this issue Aug 1, 2018 · 1 comment
Labels
♥ help improvement ⚑ perf
Milestone
Remove Keys

Comments

@ianstormtaylor
Copy link
Owner

ianstormtaylor commented Aug 1, 2018 •
edited
Loading

Do you want to request a feature or report a bug?

Improvement.

What's the current behavior?

Right now the AfterPlugin use keys for all of their logic, but using paths would be much faster. For example, looking up nodes by anchorKey in onSelect. The specific places are:

  • After.onCut
  • After.onDrop
  • After.onInput
  • After.onKeyDown
  • After.onSelect
@ianstormtaylor ianstormtaylor changed the title convert Before/AfterPlugin to use paths convert AfterPlugin to use paths Aug 1, 2018
@ianstormtaylor ianstormtaylor mentioned this issue Aug 14, 2018
Closed
@ianstormtaylor ianstormtaylor added this to the Remove Keys milestone Aug 31, 2019
@ianstormtaylor ianstormtaylor mentioned this issue Nov 6, 2019
Closed
@ianstormtaylor
Copy link
Owner Author

Fixed by #3093.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
♥ help improvement ⚑ perf
Projects
None yet
Milestone
Remove Keys
Development

Successfully merging a pull request may close this issue.

Next ianstormtaylor/slate
1 participant
@ianstormtaylor