Support rails 5.1 #13
Conversation
The specs for this version were failing with the following exception:
Mysql2::Error: All parts of a PRIMARY KEY must be NOT NULL; if you need
NULL in a key, use UNIQUE instead:
CREATE TABLE `balloons` (
`id` int(11) DEFAULT NULL auto_increment PRIMARY KEY,
`color` enum('red','gold') DEFAULT 'gold' NOT NULL,
`size` enum('small','medium','large')
) ENGINE=InnoDB
Same effect, but limited to ActiveRecord's logging only
Instead of defining all helper methods on Object
This makes it easier to create/drop the databases. See: https://github.com/rails/rails/blob/v5.0.7/activerecord/lib/active_record/tasks/database_tasks.rb
For more info see: * travis-ci/travis-ci#8978 * travis-ci/travis-ci#8969
mcls
force-pushed
the
mcls/rails-5.1
branch
4 times, most recently
from
72e5375
to
65da3ae
Compare
…ments (given 0, expected 1)
[FIX] rails db:create failed with wrong number of arguments
|
@iangreenleaf : what are your thoughts on this? My opinion is that it is a high quality pull request with some nice infrastructure additions to the test suite. I would love to see this merged into master and a new version of the gem to be released. Until then, I will have to work around this fix not being applied by forking https://github.com/fruwe/native_enum . |
|
@gerryster thanks for the review and the nudge! You're right, I should get this merged and I feel bad that I haven't done so yet. It's been on my to-do list for months now and just keeps slipping down. I'll aim to get to it this week. |
|
Thanks a lot @iangreenleaf! Let me know if there is anything I can do to help. |
|
One thing to mention is that I've been using this branch successfully on Rails 5.2. |
|
Done! Thank you @mcls and @fruwe for the good code and @gerryster for the review and gentle nudge. This is now released as v2.0.0. |
|
Thanks! |
|
Thanks again @iangreenleaf ! |
This builds upon my previous changes form #12 to support rails 5.1
Related issue: #11
Note: I also decided to switch to using
appraisalto make it a bit easier to test the different ruby version and Gemfile combinations. The Travis config was also updated to excluded unsupported ruby version and Gemfile combos.