Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add nvm shim for running nvm commands #168

Merged
merged 18 commits into from
Feb 22, 2022

Conversation

iamogbz
Copy link
Owner

@iamogbz iamogbz commented Feb 20, 2022

Description

Fixes #149 - by making nvm an executable shim that pipes arguments to nvm shell function

$ which nvm
/workspace/.pip-modules/bin/nvm

Changes

  • Add nvm shim to run nvm commands
  • Reduced verbosity of error printed when process run fails
  • Refactored process run to alway handle interrupts and errors

Checklist

  • This PR has updated documentation
  • This PR has sufficient testing

Comments

  • Used a temp file because python cannot execute bash sourcing directly

@iamogbz iamogbz force-pushed the iamogbz/instructions-for-how-to-149 branch from 7e07ce7 to d237d40 Compare February 21, 2022 14:53
@coveralls
Copy link

coveralls commented Feb 21, 2022

Coverage Status

Coverage decreased (-0.9%) to 93.878% when pulling 9f8d2a5 on iamogbz/instructions-for-how-to-149 into be6c766 on master.

@iamogbz iamogbz marked this pull request as ready for review February 22, 2022 00:01
@iamogbz iamogbz merged commit 4015efd into master Feb 22, 2022
@iamogbz iamogbz deleted the iamogbz/instructions-for-how-to-149 branch February 22, 2022 00:05
iamogbz pushed a commit that referenced this pull request Feb 22, 2022
# [1.1.0](v1.0.5...v1.1.0) (2022-02-22)

### Features

* add nvm shim for running nvm commands ([#168](#168)) ([4015efd](4015efd))
@iamogbz
Copy link
Owner Author

iamogbz commented Feb 22, 2022

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instructions for how to use shims along with nvm commands
2 participants