Add support for empty values in NumberEditor #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achernenko-pp
force-pushed
the
numbereditor-empty-values
branch
from
5fd990e
to
3f61618
Compare
achernenko-pp
force-pushed
the
numbereditor-empty-values
branch
from
3f61618
to
b068ebd
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done?
This PR enables empty values in
ValueFields backed byNumberEditor. The intended use case is being able to expressnilvalues. Internally, empty values are mapped toNSDecimalNumber.notANumber. A proper implementation would require makingTextEditor.valueoptional, but that would be a dramatic change of the API, so while the proposed solution is not ideal, it is much more conservative.Empty values are enabled using the
allowsEmptyValuesparameter in theNumberEditorinitializer, after which this behavior cannot be changed. This is done to avoid overcomplicating the internal logic inNumberEditor. Besides, it is probably unlikely that the desired behavior for a field will need to change during the lifetime of an editor.