Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inline styling from AppUI packages #318

Closed
NancyMcCallB opened this issue May 15, 2023 · 2 comments
Closed

Remove inline styling from AppUI packages #318

NancyMcCallB opened this issue May 15, 2023 · 2 comments

Comments

@NancyMcCallB
Copy link
Contributor

NancyMcCallB commented May 15, 2023

Use a strict CSP as our main method for mitigating XSS attacks. Part of this is prevention of inline styles
Content security policyContent Security Policy can significantly reduce the risk and impact of cross-site scripting attacks in modern browsers.

@raplemie
Copy link
Contributor

@kckst8 Can you provide which part is causing problem with the rule ? React should already handle correctly the style props by assigning them directly according to facebook/react#5878 (comment), so I suppose it is not what is causing issues (like resizing a panel or moving a floating widget around)

@raplemie
Copy link
Contributor

After internal discussions with @kckst8, there is not current issue direclty with AppUI packages infringing no-style CSP, so I'll close this and we can create other issues if specific components turns out to be problematic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants