diff --git a/CHANGELOG.md b/CHANGELOG.md index b5aaac91c0f..dac9f1f4422 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,9 @@ release. ### Traces +- Add InstrumentationLibrary to Sampler.ShouldSample. + ([#1850](https://github.com/open-telemetry/opentelemetry-specification/pull/1850)) + ### Metrics ### Logs diff --git a/spec-compliance-matrix.md b/spec-compliance-matrix.md index 2cfdd2d748b..4cac39fa7b0 100644 --- a/spec-compliance-matrix.md +++ b/spec-compliance-matrix.md @@ -75,6 +75,7 @@ formats is required. Implementing more than one format is optional. | [Sampling](specification/trace/sdk.md#sampling) | | | | | | | | | | | | | | Allow samplers to modify tracestate | | + | + | | + | + | + | | + | + | - | + | | ShouldSample gets full parent Context | | + | + | + | + | + | + | | + | + | - | + | +| ShouldSample gets InstrumentationLibrary | | | | | | | | | | | | | | [New Span ID created also for non-recording Spans](specification/trace/sdk.md#sdk-span-creation) | | + | + | | + | + | + | | + | + | - | + | | [IdGenerators](specification/trace/sdk.md#id-generators) | | + | + | | + | + | | | + | + | | + | | [SpanLimits](specification/trace/sdk.md#span-limits) | X | + | + | | + | + | | | | - | | + | diff --git a/specification/trace/sdk.md b/specification/trace/sdk.md index f6114d4ed87..ed46bbf6df6 100644 --- a/specification/trace/sdk.md +++ b/specification/trace/sdk.md @@ -210,6 +210,10 @@ Returns the sampling Decision for a `Span` to be created. * Collection of links that will be associated with the `Span` to be created. Typically useful for batch operations, see [Links Between Spans](../overview.md#links-between-spans). +* `InstrumentationLibrary` (name and version) of the `Span` to be created. + +Note: Implementations may "bundle" all or several arguments together in a single +object. **Return value:**