-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review autolaunch behaviour when launch is NOT detected. #7512
Comments
2 1 But, just READY isn’t quite so clear. Ready for what? Perhaps changing the wording to READY TO LAUNCH would be clearer and more explicit. The word to in there, also backs up that the launch hasn’t been detected. 3 Ultimately, I believe that the launch detection sanity checking should be performed by 2. This should be in iNav now. So the issue may be that this needs some fine tuning. |
2 1 3 |
1 2 The issue with the baro/altitude is how to calculate the detection.
Ultimately, this is why the GPS was used. It can determine a non-triggered launch much more precisely. 3 |
2 |
It's definitely something that can be looked at. I'm not quite sure how the "Upon turning on autolaunch mode, take the current baro reading." part would work if launch is permanently enabled. But I guess an easy work around would be if launch is enabled (via whatever method), take the baro alt reading when the model is armed. Maybe a minimum of 5 metres. That should be a big enough difference. It would be interesting to read @avsaase thoughts on this. As he wrote the GPS based detection. Alex, what do you think about this as a fall-back, if GPS is not installed? |
I guess if launch is permanently enabled then reading baro after boot would make the most sense if this setting is enabled. An alternative to using baro to detect launch, is to just use it to display an osd warning message to alert the pilot that the aircraft finds itself in an unexpected situation. |
The other possibility here is to allow the launch to be cancelled by moving the sticks with the throttle NOT low but only if idle launch throttle has been set and the throttle stick position is no higher than the idle setting + some margin perhaps. Seems to me that if the "idle" launch throttle set is sufficient to keep the plane aloft it's already generating reasonable thrust so the safety issue with the motor suddenly starting when the launch is cancelled using the sticks isn't such a problem. |
There is still a chance of bumping sticks before launching though. While the idle throttle is already spinning the prop, so you are aware of it. If you accidentally exit launch mode before throwing, there is no warning. This could result in failed launches. So would this lock the throttle to idle? Or is it reliant on the throttle stick position? Only people usually set the throttle stick to post-launch cruise throttle, which could be higher than idle in a good percentage of cases. Could iNav exit the launch mode, but keep the throttle at idle, regardless of where the throttle setpoint is. Then if the throttle is lowered and raised, the pilot regains control of the throttle. That way they can continue the flight, not just land on idle and launch again. |
This reverts to the throttle set by the stick position if aborted. Abort won't work if the stick position is set higher than launch idle throttle but I'm thinking the launch idle must be fairly high to keep the plane flying so maybe this would work in most cases where the plane has enough "idle" throttle to fly off. There is also the possibility of allowing a higher throttle stick setting than launch idle throttle, by some margin that doesn't result in too significant an increase in thrust if aborted. I don't think accidentally aborting by knocking the sticks before launch is much different to the current situation. Launch can be accidentally aborted now if it's set as a feature and you knock the sticks before raising the throttle. And it can also be accidentally aborted immediately after launch is detected cancelling it close to the ground, it's always a risk if you're careless with the transmitter. It should be obvious it's aborted prior to launch by the beeper stopping, launch OSD messages disappearing and control surfaces resetting. This is more about avoiding an out of control plane continuing to fly than saving the plane itself and also the fact that people instinctively try and use the pitch/roll stick to regain control and probably even raise the throttle rather than lowering it. Remembering to lower the throttle instead to regain control when in panic mode is counter intuitive. |
Isn't the launch aborted by just flicking the launch switch to off? This won't work for autolaunch always on but this feature has some serious drawbacks and safety hazards so I dont really encourage using it. I agree with @MrD-RC that Ready to Launch is a clearer message than Waiting to Launch. |
Fixed with gps speed trigger and new Autolaunch messages a while ago. |
Recently, I had an incident where my wing wouldn't respond to control inputs during an autolaunch. Upon DVR review, it appears the fc did not detect the launch, and nav_fw_launch_idle_thr was sufficiently high that the wing had enough thrust to sustain a climb (and as the throw wasn't completely level, also banked to the left). I don't expect this to be 'solved' but most accidents are a result of a chain of bad outcomes, and maybe there are a few things we can do to break that chain.
Current Behavior
In autolaunch mode, the controls are disabled until the fc detects the launch.
Desired Behavior
Mitigate the scenario of an airborne vehicle which hasn't detected launch.
Suggested Solution
Who does this impact? Who is this for?
Autolaunch users.
Additional context
FB group thread:
https://www.facebook.com/groups/INAVOfficial/posts/1276936489415666/
The text was updated successfully, but these errors were encountered: