Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP Mode Set Head doesn't automatically reset when starting new mission #6851

Closed
breadoven opened this issue Apr 19, 2021 · 2 comments · Fixed by #6852
Closed

WP Mode Set Head doesn't automatically reset when starting new mission #6851

breadoven opened this issue Apr 19, 2021 · 2 comments · Fixed by #6852

Comments

@breadoven
Copy link
Collaborator

breadoven commented Apr 19, 2021

Set up a mission with a Set Head WP that remained set until the end of the mission. Flew the mission twice without disarming but with WP mode cancelled and restarted between flights. Noticed that Set Head was still active when starting the second flight. Looking at the code there doesn't appear to be anything that cancels wpHeadingControl.mode when a new mission is started which would explain why it remained active.

Probably just needs wpHeadingControl.mode = NAV_WP_HEAD_MODE_NONE; setting in:

static navigationFSMEvent_t navOnEnteringState_NAV_STATE_WAYPOINT_INITIALIZE(navigationFSMState_t previousState)

@stronnag
Copy link
Collaborator

Indeed. Please PR.

@breadoven
Copy link
Collaborator Author

Tested and seems to do the job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants