-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v1 release] TODO list #280
Comments
Looks very interesting. May I suggest to implement an evaluation of the given cookies. I have used the integration myself for 10 months or so using the cookie method. The first 6 months it worked like a charm with no issues. Then the authentication broke for some reason. No worries, I just tried to configure it once again. It turned out to be troublesome and worked for only short periods. What I notice is the difference in amount of cookies copied from the browser.
From a normal tab with improperly cleared cookies, I furthermore got:
To help others, could it be an idea in the config + options flow to implement a check and a warning if the are more than the needed 5 cookies? Secondly, if it experiences the USER_LOGGED_OUT exception, would it be an idea to stop it from retrying?
Lastly, it seems the HTTP session contains a cookie_jar, containing cookies set by previous responses. Would it be an idea to clear this upon configuration? Simply to avoid mixing cookies from multiple sessions. |
@jnxxx thanks, good feedback! Personally I am still using the original auth method with a refresh token. The cookie method hasn't been developed by me, and the reason it isn't released yet in main, is because there are many open issues. I just finished my work on the Overkiz (Somfy) integration in core, so hopefully the coming months I will have some more time to work on Nest Protect! |
t.b.c.
The text was updated successfully, but these errors were encountered: