Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete functions or functions that can be simplified. #130

Open
kinkayd opened this issue Dec 23, 2020 · 0 comments
Open

Obsolete functions or functions that can be simplified. #130

kinkayd opened this issue Dec 23, 2020 · 0 comments

Comments

@kinkayd
Copy link

kinkayd commented Dec 23, 2020

Merge Rooms : No longer necessary, since the hash from gmcp.room.info positively identifies a room, no need to merge rooms, since different rooms will have different hashes and thus different room ID's.

function set_room : At the end of this functions, an onMoveMap event is raised... yet you have no handler to handle the event. Is this an event handled by the mapper that I haven't found?

function check_room(...) : Since rooms are positively identified by a hash, why do you check against room name and exits? Big issue I have with this, is that some rooms have exits that are not obvious. Once I use said exit, the exit is created, and thus this function no longer identifies a perfectly valid room and won't show you being in that room.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant