Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Augmentation of NextJS AppProps not being exported in type definitions #1953

Closed
priscillacamargo opened this issue Sep 20, 2022 · 3 comments
Closed
Labels

Comments

@priscillacamargo
Copy link

priscillacamargo commented Sep 20, 2022

🐛 Bug

When bumping i18next version from 11.3.0 to 12.0.1 in our nextjs application we got a typing error on our app.tsx when using the the HOC appWithTranslation(MyApp). Ts complains that the default nextjs AppProps is missing SSRConfig. Looking at i18next types definitions we found out that the type augmentation was not being exported, so we needed to manually add:

type AppProps = NextJsAppProps & {
	pageProps: SSRConfig;
};

into our app.tsx!

Environment

  • runtime version: nextjs 12.3.0
  • i18next version: 12.0.1
  • os: Mac
@adrai
Copy link
Member

adrai commented Sep 20, 2022

related? #1944

@priscillacamargo
Copy link
Author

yes, indeed related, thank you for linking it!

@stale
Copy link

stale bot commented Sep 28, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 28, 2022
@stale stale bot closed this as completed Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants