feat(agents): use prompt templates from a concrete runner #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: #219 Signed-off-by: Tomas Dvorak <[email protected]>
| @@ -83,6 +88,15 @@ export class GraniteRunner extends DefaultRunner { | |||
| return memory; | |||
| } | |||
|
|
|||
| get templates(): BeeAgentTemplates { | |||
There was a problem hiding this comment.
Now that we have this templates method, I wonder if we should be using this everywhere as opposed to using this.input.templates. If we use this templates method then we can removed the granite runner constructor code that duplicates this code.
There was a problem hiding this comment.
Yes, the template override is not necessary anymore. Removed.
Signed-off-by: Tomas Dvorak <[email protected]>
michael-desmond
approved these changes
Dec 4, 2024
matiasmolinas
pushed a commit
to matiasmolinas/bee-agent-framework
that referenced
this pull request
Dec 7, 2024
Ref: i-am-bee#219 Signed-off-by: Tomas Dvorak <[email protected]> Signed-off-by: Matias Molinas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #219