Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(llms): correct the vllm granite model_id #218

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

michael-desmond
Copy link
Contributor

Which issue(s) does this pull-request address?

Cant have a (dot) in ibmvllm backend model id, so the current ibmvllm model_id for granite is incorrect due to the inclusion of a (dot).

Description

  • Replaced the (dot) with a dash to match the backend model id.

Checklist

  • I have read the contributor guide
  • Linting passes: yarn lint or yarn lint:fix
  • Formatting is applied: yarn format or yarn format:fix
  • Unit tests pass: yarn test:unit
  • E2E tests pass: yarn test:e2e
  • Tests are included
  • Documentation is changed or added
  • Commit messages and PR title follow conventional commits

@michael-desmond michael-desmond requested a review from a team as a code owner December 3, 2024 19:58
@Tomas2D Tomas2D merged commit 643cd8e into i-am-bee:main Dec 4, 2024
2 checks passed
matiasmolinas pushed a commit to matiasmolinas/bee-agent-framework that referenced this pull request Dec 7, 2024
Signed-off-by: MICHAEL DESMOND <[email protected]>
Signed-off-by: Matias Molinas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants