Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio seek subscription #252

Open
vidicunt opened this issue Aug 21, 2022 · 3 comments
Open

Audio seek subscription #252

vidicunt opened this issue Aug 21, 2022 · 3 comments

Comments

@vidicunt
Copy link

Hello!

Subscribing to AVTransport does not notify when the user seeks the audio. How can I be notified of this?

@vidicunt vidicunt changed the title Seek subscription Audio seek subscription Aug 21, 2022
@mill1000
Copy link
Contributor

mill1000 commented Aug 22, 2022

Looks like the seek command is not switching the transport state to "TRANSITIONING" as required by the AVTransport spec.

if (output_seek(nanos) == 0) {
// TODO(hzeller): Seeking might take some time,
// pretend to already be there. Should we go into
// TRANSITION mode ?
// (gstreamer will go into PAUSE, then PLAYING)
replace_var(TRANSPORT_VAR_REL_TIME_POS, target);
}

image

This is similar to the seeking issues reported in #217, which are partially caused by the incorrect return type below which is fixed in PR #241

if (gst_element_seek(player_, 1.0, GST_FORMAT_TIME,
GST_SEEK_FLAG_FLUSH,
GST_SEEK_TYPE_SET, position_nanos,
GST_SEEK_TYPE_NONE, GST_CLOCK_TIME_NONE)) {
return -1;

@vidicunt
Copy link
Author

Thank you! I'll be waiting for the merge then

@mill1000
Copy link
Contributor

Might be worth keeping open since I don't think #241 will fully solve the seek eventing

@vidicunt vidicunt reopened this Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants