Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to hyprctl rollinglog to follow the Hyprland logs #6300

Closed
zjeffer opened this issue Jun 1, 2024 · 5 comments
Closed

Add option to hyprctl rollinglog to follow the Hyprland logs #6300

zjeffer opened this issue Jun 1, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@zjeffer
Copy link
Contributor

zjeffer commented Jun 1, 2024

Description

Right now, to follow the current logs, I run tail -f $XDG_RUNTIME_DIR/hypr/<id>/hyprland.log. I notice hyprctl rollinglog is able to show the last 50-ish lines, but not able to follow the logs.

Proposal: add a parameter (-f, --follow) to hyprctl rollinglog that follows the output similar to tail -f <file>.

@zjeffer zjeffer added the enhancement New feature or request label Jun 1, 2024
@Truenya
Copy link
Contributor

Truenya commented Jun 2, 2024

Can i try this?


UPD
Working on it. hope not in vain


UPD2
Got it! Working as proposed, for every amount of followers.
Now i have to read all stuff (local contributing guides, code style, etc)

@tchofy
Copy link

tchofy commented Jun 3, 2024

Honestly I'd be in favor of rollinglog follow by default, and optionally have a tail flag if someone has an use for it.
From the name I'd expect rolling log to be rolling, so that seems more intuitive for me.

@Truenya
Copy link
Contributor

Truenya commented Jun 3, 2024

@tchofy I think similarly, but as for me it is more correct to preserve the existing behavior(it is my first PR here).

@Truenya
Copy link
Contributor

Truenya commented Jun 14, 2024

@zjeffer i think issue can be closed as for now

@zjeffer
Copy link
Contributor Author

zjeffer commented Jun 14, 2024

Yes, thank you very much!

@zjeffer zjeffer closed this as completed Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants