Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate h to Python 3 #467

Closed
robertknight opened this issue Feb 9, 2018 · 2 comments
Closed

Migrate h to Python 3 #467

robertknight opened this issue Feb 9, 2018 · 2 comments
Labels

Comments

@robertknight
Copy link
Member

Python 2 is gradually starting to reach end of life [1] and various libraries are starting to drop support for it. We are not under any immediate pressure to finish a migration but our codebase is mostly compatible [2] and AFAIK we no longer have any dependencies that are Python 2 only. Additionally Python 3 provides various functional and performance improvements across the language, runtime and standard library.

On that basis, I'd propose that we start running tests against Python 3 and incrementally fix remaining issues, with a view to transitioning the production environment over some time in the next few months.

A rough plan of action would be:

  1. Make Travis run unit tests against Python 3, ignoring existing failures.
  2. Incrementally fix remaining compat issues
  3. Get our functional tests running against Python 3
  4. Do some testing of the app itself locally to make sure all the core functionality works
  5. Change the Docker build to use Python 3
  6. Test on QA
  7. Deploy to prod
  8. Profit!

[1] See Pylons/pyramid#2903
[2] I got all the unit + functional tests passing locally with a diff of ~250 lines over master at 66f83ba23.

@robertknight robertknight added the h label Feb 9, 2018
@ajpeddakotla
Copy link

Note - add documentation for devs/external users on the Python 3 requirement.

@lyzadanger
Copy link

Closing in favor of hypothesis/h#5384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants