Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last connected wallet spams to connect in new session #393

Open
codingki opened this issue Jan 15, 2024 · 6 comments
Open

Last connected wallet spams to connect in new session #393

codingki opened this issue Jan 15, 2024 · 6 comments

Comments

@codingki
Copy link

When opening a new session, the last wallet connected send spams to connect

Repro steps:

  1. connect your dapp with leap wallet
  2. close session/tabs
  3. lock your wallet
  4. open your dapp again
@liujun93
Copy link
Contributor

liujun93 commented Feb 1, 2024

It seems this is not a general issue for all wallets. I tried Keplr and it only popup once. I'll ask Leap team about it.

@phips28
Copy link

phips28 commented Feb 6, 2024

I have also seen this.

How can we disable auto-connect?

@barun1313
Copy link

Hey folks, thanks for bringing this up! We are looking into this right now

@phips28
Copy link

phips28 commented Feb 9, 2024

would be great to have a config flag (reconnect: true) to disable the auto reconnect.

I think this line makes the problem (for us): https://github.com/cosmology-tech/cosmos-kit/blob/main/packages/core/src/manager.ts#L394

Asking the user to reconnect, also on page re-load when he declined on the last connect request. thats annoying UX.

@baryon2
Copy link
Contributor

baryon2 commented Feb 12, 2024

@liujun93 @codingki This issue has been fixed in the latest version (0.10.5) of leap extension.

@phips28
Copy link

phips28 commented Feb 12, 2024

Ok, I still saw this with Keplr. So maybe we are talking about 2 different topics 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants