Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusted wrapCallback to not fail if no content-type returned (e.g. errors) #25

Closed
wants to merge 2 commits into from
Closed

Adjusted wrapCallback to not fail if no content-type returned (e.g. errors) #25

wants to merge 2 commits into from

Conversation

ajlozier
Copy link
Contributor

@ajlozier ajlozier commented Sep 30, 2019 •
edited
Loading

Fixes #24

@ajlozier
Added test for 429 error which failed due to TypeError; adjusted wrap…
3b0485b 
…Callback to not fail if no content-type returned
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 3b0485b on WaitrInc:fix/issue-24 into a63faa1 on hyperwallet:master.

@adwivedi-hw
Copy link

For 429, the expected response contains header as well as body. Even if it doesn't behave as expected, the fix should be done in HW2. This change in SDK is not required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError thrown when any no-content response returned
3 participants
@ajlozier @coveralls @adwivedi-hw