Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comparing a unloaded scope with a loaded empty scope returns TRUE #81

Closed
catmando opened this issue Dec 7, 2018 · 1 comment
Closed
Labels
bug Something isn't working ready-to-release Internal Use Only: Has been fixed, specs passing and pushed to edge branch
Milestone

Comments

@catmando
Copy link
Contributor

catmando commented Dec 7, 2018

scope1 has been loaded, and is empty
scope2 has not been loaded (its just a vector still)

if you compare them it comes out true, since atm scope2 is also empty, but its a vector only.

fix needs some investigation but probably its just a matter of checking to see if either collection is nil, then compare the vectors. Possibly don't even need to compare vectors since IIRC the collection system insures that the same vector will return the same collection object anyway.

@catmando
Copy link
Contributor Author

closed. See example batch4/scope_spec.rb it 'will not treat an unloaded scope as equal to an empty loaded scope'

@catmando catmando added the ready-to-release Internal Use Only: Has been fixed, specs passing and pushed to edge branch label Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready-to-release Internal Use Only: Has been fixed, specs passing and pushed to edge branch
Projects
None yet
Development

No branches or pull requests

1 participant