Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation instructions #307

Closed
reedstonefood opened this issue May 4, 2020 · 4 comments
Closed

Fix installation instructions #307

reedstonefood opened this issue May 4, 2020 · 4 comments

Comments

@reedstonefood
Copy link

The installation instructions make reference to running this command:

rails new MyApp -T -m https://rawgit.com/hyperstack-org/hyperstack/edge/install/rails-webpacker.rb

However, this does not work as rawgit.com was turned off last year.

I believe this should be changed to:

rails new MyApp -T -m https://raw.githubusercontent.com/hyperstack-org/hyperstack/edge/install/rails-webpacker.rb

@barriehadfield
Copy link
Contributor

@reedstonefood thank you for that! I will address this over the weekend, or if you can issue a PR I can accept that change as the docs are built automatically from the readme files.

@catmando is not keen on the Rails template approach so I think we should remove it from the docs. Seems it often creates issues for us.

@catmando
Copy link
Contributor

catmando commented May 5, 2020

@barriehadfield I'm good either way, but I am not going to maintain them is all. If we keep the templates we should write some specs. You could adapt them from the generators specs I think.

Also if you keep the templates, I suggest investigating getting the basics of the generator and template to work on the same code files, thus reducing maintenance.

@reedstonefood
Copy link
Author

The website pronounces it can be up and running within 5 minutes. I've been trying for about 5 hours acorss a few days and I don't have a working version yet, because the tutorial is out of date, because of #306 and because of a few other things too.

For a product that says it makes things easy, I think a template that can get you up and running quickly is important to have. Just my 2c.

@catmando
Copy link
Contributor

closed as duplicate of #336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants