Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no mutation signaled if a scope changes async #164

Closed
catmando opened this issue Apr 14, 2019 · 0 comments
Closed

no mutation signaled if a scope changes async #164

catmando opened this issue Apr 14, 2019 · 0 comments
Labels
bug Something isn't working ready-to-release Internal Use Only: Has been fixed, specs passing and pushed to edge branch
Milestone

Comments

@catmando
Copy link
Contributor

if a remote delete is received everything works except observers of the scope are not notified.

This because collections never notify while data is loading (not sure why)

It seems though that the only broken case is when a nested scope is updated by an async notification. So a workaround is to add this code

          Hyperstack::Internal::State::Mapper.bulk_update do
            Hyperstack::Internal::State::Variable.set(target, :collection, target.collection)
          end

immediately after

          target.replace loaded_collection

in server_data_cache.rb

@catmando catmando added this to the alpha1.4 milestone Apr 14, 2019
@catmando catmando added the bug Something isn't working label Apr 14, 2019
catmando added a commit that referenced this issue Apr 15, 2019
@catmando catmando added the ready-to-release Internal Use Only: Has been fixed, specs passing and pushed to edge branch label Apr 15, 2019
@catmando catmando modified the milestones: alpha1.4, alpha1.5 Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready-to-release Internal Use Only: Has been fixed, specs passing and pushed to edge branch
Projects
None yet
Development

No branches or pull requests

1 participant