iOS 11 & iPhone X

[Droppix]

Don't work with iOS 11 and iPhone X.
New release ?

[AndrewGable]

I agree, we are having issues with this on the iPhone X simulator. Here is one example of when we show aMurmur

Do you have any ides on how to fix this?

[onmyway133]

@Droppix @AndrewGable Hi, this is known issue. We 'll try to fix this during the swift 4 migration

[AndrewGable]

Awesome, is the proposed fix to extend the Murmur completley bellow the notch?

[derikflanary]

May I ask when the Swift 4 migration is expected to be completed?

[wowlocal]

Hey guys, i fix this here #179

[zenangst]

Hey folks, I just merged #179 into master. This seems to do the trick when I tested, please confirm that it works for you guys :) I also med #183 to reduce some code-duplication, that will be merged shortly.

[zenangst]

@derikflanary I think when #183 is merged we can make a new 5.x version and then merge one of the swift4 PR's and make a 6.x release.

[onmyway133]

@Droppix @wowlocal @derikflanary Hi, you can check https://github.com/hyperoslo/Whisper/releases/tag/6.0.0. This is mostly language update, and small fixes to make it look nice on iPhone X. There's some other issues and PRs that we will try to deal with soon

[barnaclejive]

Was this tested on non-iPhone X? I just pulled tag 6.0.0 and ran it on an iPhone 8 Simulator and the Murmur will drop down below the status bar. I assume this is how it has to work on iPhone X, but on other devices it should still just drop into the status bar area, not below it.

[jondwillis]

@barnaclejive

I have implemented Whistles in my own branch such that they appear under the status bar on iPhone X, but extend all the way to the top of the screen. Additionally, I have also preserved the behavior where they appear over the status bar on other devices.

See commit: jondwillis@afcd471

Someone should disentangle and clean up my fork and do a pull request if they wish to see this behavior in the mainline. In my application, safeAreaInsets do not change, but to be production-ready, the final version of this should observe safeAreaInsetsDidChange

Though I subjectively like extending from the top edge on iPhone X, doing this may be against Apple's guidelines, and may result in a App Store review rejection. I have noticed that snapchat changed its Whistle-like implementation on iPhone X to look kind of like a push notification does; it is below the status bar, and does not touch any edges.

Shouts/Announcements also need to be fixed for iPhone X and AFAIK that hasn't been done.

For reference here is what Snapchat is doing:

[jondwillis]

Update: I was able to publish an app with this Whistle behavior to the App Store. So, anecdotally, it is acceptable under Apple's Guidelines.

[onmyway133]

@barnaclejive Hi, can you check https://github.com/hyperoslo/Whisper/releases/tag/6.0.2 which merged #193
@jondwillis We will go with full notch extend for now 👍
I will close this in favor of #188