Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case insensitive config parameters #3358

Closed
Arjentix opened this issue Apr 5, 2023 · 4 comments
Closed

Case insensitive config parameters #3358

Arjentix opened this issue Apr 5, 2023 · 4 comments
Assignees
Labels
config-changes Changes in configuration and start up of the Iroha iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@Arjentix
Copy link
Contributor

Arjentix commented Apr 5, 2023

@arndey mentioned that we have WSV_WASM_RUNTIME_CONFIG in upper case, but WSV_ACCOUNT_METADATA_LIMITS in lower case:
https://github.com/hyperledger/iroha/blob/iroha2-dev/docs/source/references/config.md.
Let's make them case insensitive.

@mihir1739
Copy link

Can I work on this ? If I could be assigned this issue it would be even better.

@appetrosyan
Copy link
Contributor

if you know what you're doing, go ahead.

Before you start, make sure you have

rustup toolchain add nightlly-2022-12-22

and read Contributing.md. Make sure your commits are signed-off (git commit -s) and that you don't use more commits than necessary (one per issue is fine, just amend the previous one, or squash before or during rebase). Try to avoid updating from upstream via merge, use rebase git pull --rebase).

I'm assigning the issue to you. Let's keep in touch.

@appetrosyan appetrosyan added iroha2-dev The re-implementation of a BFT hyperledger in RUST config-changes Changes in configuration and start up of the Iroha labels Jun 4, 2023
@mversic
Copy link
Contributor

mversic commented Sep 26, 2023

@mihir1739 any progress on this one?

@mversic
Copy link
Contributor

mversic commented Jan 24, 2024

this should not be an issue anymore after #2585

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config-changes Changes in configuration and start up of the Iroha iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

No branches or pull requests

4 participants