Skip to content
This repository has been archived by the owner on Feb 29, 2024. It is now read-only.

Add a podspec for objective-c indy wrapper in non-binary distribution #2442

Closed
wants to merge 1 commit into from

Conversation

conanoc
Copy link
Contributor

@conanoc conanoc commented Nov 10, 2021

Signed-off-by: conanoc [email protected]

Previous podspec libindy-objc.podspec has several issues:

  • It is based on pre-built binary and the binaries are not provided since v1.8.2
  • Old binaries do not support newer versions of swift
  • Binary frameworks cannot support multiple versions of swift

Source based podspec would be more convenient because we do not have to prepare binaries and there is no version dependency for swift.
Some notes about this commit:

  • The podspec filename have to be the same as the name of the framework. So, I could not keep the previous name libindy-objc.podspec.
  • The lastest version of libindy is v1.16.0, but one source file of the wrapper(wrappers/ios/libindy-pod/Indy/Wrapper/IndyErrors.h) had a bug(comma missing) and was fixed later. So, tag v1.16.0 cannot be used for ios wrapper.
  • Used OpenSSL-XM(1.0.210.1) pod instead of OpenSSL(1.0.210) pod because OpenSSL is not compatible with the latest version of cocoapods. OpenSSL podspec would be better copied to indy-sdk repo with fixes done in OpenSSL-XM.

@WadeBarnes
Copy link
Contributor

A fix for the build issues has been implemented (#2470). Please rebase this PR on the latest from the main branch so it is no longer blocked by the related build issues.

@conanoc conanoc force-pushed the podspec branch 2 times, most recently from 8d045b3 to 0a03bdd Compare January 26, 2022 06:00
@conanoc
Copy link
Contributor Author

conanoc commented Jan 26, 2022

@WadeBarnes After the rebase, build-image-wrapper-base is failing. Any idea?

@WadeBarnes
Copy link
Contributor

WadeBarnes commented Jan 31, 2022

@WadeBarnes After the rebase, build-image-wrapper-base is failing. Any idea?

@conanoc, I missed updating the Rust version in a spot; #2475. You won't need to rebase again since the GHA workflows do not block the ability to merge.

@WadeBarnes
Copy link
Contributor

@mirgee, Is this something you could review?

@WadeBarnes WadeBarnes added the wont-address-project-depreciated This Issue or PR will not be addressed. The project has been depreciated. label Oct 24, 2023
@ryjones ryjones closed this Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
wont-address-project-depreciated This Issue or PR will not be addressed. The project has been depreciated.
Development

Successfully merging this pull request may close these issues.

3 participants