Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: publish to OSSHR repository #188

Merged
merged 20 commits into from
Aug 7, 2024
Merged

fix: publish to OSSHR repository #188

merged 20 commits into from
Aug 7, 2024

Conversation

yshyn-iohk
Copy link
Member

@yshyn-iohk yshyn-iohk commented Aug 7, 2024

Description:

In this PR, the build file was fixed to add the metadata to the pom.xml files and publish these packages to the OSSHR repository.
Despite removing the if statement and filtering the project that should be published, the number of packages is the same. Refer to the previous publication and the new publication of the beta version

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

yshyn-iohk and others added 18 commits August 2, 2024 20:45
….24...v1.4.0-beta.1) (2024-08-02)

### Features

* add a beta branch and rust-init installer to the release flow ([dc8fd38](dc8fd38))

Signed-off-by: Hyperledger Bot <[email protected]>
Signed-off-by: Yurii Shynbuiev <[email protected]>
….0-beta.1...v1.4.0-beta.2) (2024-08-05)

### Features

* add --info to the CI ([b85edb7](b85edb7))
* rollback oss.sonatype url and upgrade a gradle-release-plugin to 1.9.2 version ([23e5be8](23e5be8))

Signed-off-by: Hyperledger Bot <[email protected]>
Signed-off-by: Yurii Shynbuiev <[email protected]>
Signed-off-by: Yurii Shynbuiev <[email protected]>
….0-beta.2...v1.4.0-beta.3) (2024-08-06)

### Features

* add --info to the CI ([1fa8205](1fa8205))
* add --info to the CI ([8dbd048](8dbd048))
* replace maven section with nexusPublishing ([56824ec](56824ec))

Signed-off-by: Hyperledger Bot <[email protected]>
Signed-off-by: Yurii Shynbuiev <[email protected]>
Signed-off-by: Yurii Shynbuiev <[email protected]>
….0-beta.3...v1.4.0-beta.4) (2024-08-06)

### Features

* publish update ([2e1ee7d](2e1ee7d))
* update the publishing info ([31f0161](31f0161))

Signed-off-by: Hyperledger Bot <[email protected]>
# Conflicts:
#	CHANGELOG.md
#	Package.swift
#	build.gradle.kts
#	gradle.properties
Copy link

github-actions bot commented Aug 7, 2024

Code Coverage

Total Project Coverage 88.94%

@yshyn-iohk yshyn-iohk merged commit 8f98b5a into main Aug 7, 2024
4 checks passed
@yshyn-iohk yshyn-iohk deleted the beta branch August 7, 2024 07:17
yshyn-iohk added a commit that referenced this pull request Aug 7, 2024
Signed-off-by: Yurii Shynbuiev <[email protected]>
Signed-off-by: Hyperledger Bot <[email protected]>
Co-authored-by: Hyperledger Bot <[email protected]>
yshyn-iohk pushed a commit that referenced this pull request Aug 7, 2024
…(2024-08-07)

### Bug Fixes

* publish to OSSHR repository ([#188](#188)) ([8f98b5a](8f98b5a))

Signed-off-by: Hyperledger Bot <[email protected]>
@@ -42,6 +42,7 @@ jobs:

- name: "Install Java ${{ env.JAVA_VERSION }}"
uses: actions/setup-java@v4
continue-on-error: true

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait
why this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for asking.
For some reason, the release flow fails at the Post Install Task
For instance, here: https://github.com/hyperledger/identus-apollo/actions/runs/10279883067
The entire release fails even if the packages are published and the chore commit is pushed.

I could not find a solution for this now except to add continue-on-error to the Post Install Java 17 task.

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#189 for tracking

@yshyn-iohk
Copy link
Member Author

🎉 This issue has been resolved in version 1.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

yshyn-iohk added a commit that referenced this pull request Aug 7, 2024
…4.2](v1.4.1...v1.4.2) (2024-08-07)

### Bug Fixes

* publish to OSSHR repository ([#188](#188)) ([8f98b5a](8f98b5a))

Signed-off-by: Hyperledger Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants