Add base image and fix python version #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Enrique Lacal <[email protected]>
EnriqueL8
requested review from
awrichar,
peterbroadhurst and
shorsher
as code owners
awrichar
reviewed
May 21, 2024
| @@ -22,7 +24,7 @@ RUN curl -sfL https://raw.githubusercontent.com/aquasecurity/trivy/main/contrib/ | |||
| RUN trivy fs --format spdx-json --output /sbom.spdx.json /SBOM | |||
| RUN trivy sbom /sbom.spdx.json --severity UNKNOWN,HIGH,CRITICAL --exit-code 1 | |||
|
|
|||
| FROM node:20-alpine3.19 | |||
| FROM $BASE_IMAGE | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
fixing this with Build IMAGe ARG
awrichar
approved these changes
May 21, 2024
Signed-off-by: Enrique Lacal <[email protected]>
EnriqueL8
added a commit
to kaleido-io/firefly-tokens-erc1155
that referenced
this pull request
May 28, 2024
Add base and image args and fix python version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
BASE_IMAGEarg for Dockerfile