Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker samples gallery? #12

Open
peterbroadhurst opened this issue Jul 1, 2021 · 0 comments
Open

Docker samples gallery? #12

peterbroadhurst opened this issue Jul 1, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@peterbroadhurst
Copy link
Contributor

peterbroadhurst commented Jul 1, 2021 •
edited
Loading

Wonder if it would be valuable to have a simple docker build of this repo, and maybe as a follow-on to include it as a --with-samples option on the FireFly CLI.

Would mean a little restructure in terms of how we add new samples into the repo, as they'd need to become folders inside of one React App, rather than a set of separate react apps.

Obviously wouldn't really help for the CLI part (although it could too I guess, with a docker run ...)
@peterbroadhurst peterbroadhurst added the enhancement New feature or request label Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peterbroadhurst