Blockchain operations moving from Failed to Pending

[matthew1001]

FireFly integration tests are seeing blockchain operations move from Failed to Pending status after evm revert errors:

[33;1mfirefly_core_0_1  |[0m [2023-04-05T00:29:46.239Z] DEBUG ethereum updating operation default:f79a082e-3283-4659-a378-5d3e737f9381 status=Failed error=FF10111: Error from ethereum connector: FF23021: EVM reverted: CustomPin: FireFly address has not been set ns=default pid=1
[33;1mfirefly_core_0_1  |[0m [2023-04-05T00:29:46.508Z] DEBUG ethereum updating operation default:f79a082e-3283-4659-a378-5d3e737f9381 status=Failed error=FF10111: Error from ethereum connector: FF23021: EVM reverted: CustomPin: FireFly address has not been set ns=default pid=1
[33;1mfirefly_core_0_1  |[0m [2023-04-05T00:29:47.021Z] DEBUG ethereum updating operation default:f79a082e-3283-4659-a378-5d3e737f9381 status=Failed error=FF10111: Error from ethereum connector: FF23021: EVM reverted: CustomPin: FireFly address has not been set ns=default pid=1
[33;1mfirefly_core_0_1  |[0m [2023-04-05T00:29:48.033Z] DEBUG ethereum updating operation default:f79a082e-3283-4659-a378-5d3e737f9381 status=Failed error=FF10111: Error from ethereum connector: FF23021: EVM reverted: CustomPin: FireFly address has not been set ns=default pid=1
[33;1mfirefly_core_0_1  |[0m [2023-04-05T00:29:50.049Z] DEBUG ethereum updating operation default:f79a082e-3283-4659-a378-5d3e737f9381 status=Pending ns=default pid=1
[33;1mfirefly_core_0_1  |[0m [2023-04-05T00:29:55.662Z] DEBUG ethereum updating operation default:f79a082e-3283-4659-a378-5d3e737f9381 status=Succeeded ns=default pid=1

It seems wrong for an operation that has reached a "final" state of either Failed or Succeeded to ever move out of that state.

[Chengxuan]

From the logs, the failed status seems not to be determined by the connector. It's determined by the Firefly Core logic. If it cannot submit a blockchain transaction and would eventually succeed through retrying, they it shouldn't return Failed status.