Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename --channel-id to --channelID in osadmin #2315

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Rename --channel-id to --channelID in osadmin #2315

merged 1 commit into from
Jan 27, 2021

Conversation

jcastrence
Copy link
Contributor

Type of change

  • Improvement (improvement to code, performance, etc)

Description

  • Rename --channel-id flag in osadmin to --channelID to match the rest of fabric flags

@jcastrence jcastrence requested review from a team as code owners January 27, 2021 15:16
sykesm
sykesm previously approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@sykesm sykesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sykesm sykesm enabled auto-merge (rebase) January 27, 2021 15:29
@ale-linux
Copy link
Contributor

thanks for your PR! It looks like you may have missed one spot here

https://dev.azure.com/Hyperledger/Fabric/_build/results?buildId=29062&view=logs&j=6b58850f-3858-5a05-33e2-5e41cbf03c4e&t=bddec1cf-ba37-5883-9c3e-fd1e8608f9a1&l=98

@sykesm sykesm disabled auto-merge January 27, 2021 15:47
@lindluni lindluni enabled auto-merge (rebase) January 27, 2021 18:02
@lindluni lindluni merged commit 2a9251c into hyperledger:master Jan 27, 2021
@pamandrejko
Copy link
Contributor

@lindluni Can we backport this to relase-2.3? Not sure I have authority to do that?

@wlahti
Copy link
Contributor

wlahti commented Jan 27, 2021

@Mergifyio backport release-2.3

@mergify
Copy link

mergify bot commented Jan 27, 2021

Command backport release-2.3: success

Backports have been created

@mergify mergify bot mentioned this pull request Jan 27, 2021
Merged
@denyeart
Copy link
Contributor

@sykesm @ale-linux @lindluni Shouldn't a flag change require an associated release note entry? I'm good with the change since it is so soon after the introduction in v2.3.0 release and therefore not many people are using it yet, just want to make sure maintainers identify release note candidates during review. I'm happy to do this one since it already got merged.

@gqqnbig gqqnbig mentioned this pull request Sep 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindluni lindluni lindluni approved these changes

@sykesm sykesm sykesm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jcastrence @ale-linux @pamandrejko @wlahti @denyeart @sykesm @lindluni @jrc-ibm