Skip to content

Commit

Permalink
[FAB-10954] data race core/comm/producer
Browse files Browse the repository at this point in the history
TestUpdateEndpoints was modifying package scoped variables while all of
the other tests were concurrently reading it. This is a race.

Disabling parallel execution for this test.

Change-Id: Ic3979ddba54685ced5ac9eb7111d0d3cf4b34053
Signed-off-by: Matthew Sykes <[email protected]>
  • Loading branch information
sykesm committed Jul 2, 2018
1 parent 003566e commit 9dcaed6
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion core/comm/producer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ func TestUpdateEndpoints(t *testing.T) {
}

func TestDisableEndpoint(t *testing.T) {
t.Parallel()
orgEndpointDisableInterval := EndpointDisableInterval
EndpointDisableInterval = time.Millisecond * 100
defer func() { EndpointDisableInterval = orgEndpointDisableInterval }()
Expand Down

0 comments on commit 9dcaed6

Please sign in to comment.