Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cleanup): deleted deprecated files and folders #3370

Closed
wants to merge 0 commits into from
Closed

chore(cleanup): deleted deprecated files and folders #3370

wants to merge 0 commits into from

Conversation

VRamakrishna
Copy link
Contributor

  • Deleted 'docs-cactus' and 'weaver/docs' folders.
  • Ensured that the latest contents in the above are reflected in the 'docs' folder.
  • Updated MAINTAINERS.md file with contents from 'weaver/MAINTAINERS.md'.
  • Deleted unnecessary 'MAINTAINERS.md' and 'CONTRIBUTING.md' in the 'weaver' folder.
  • Fixed indentations and removed dead code in source files.

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@VRamakrishna
Copy link
Contributor Author

VRamakrishna commented Jul 1, 2024

@outSH @petermetz I reviewed the changes in docs-cactus since the new documentation pages were created (https://github.com/hyperledger/cacti/commits/main/docs-cactus) and noticed that some of them were not reflected in the docs folder. I tried to update the contents of the docs folder as best I could. Please check for accuracy.

@sandeepnRES Please review to ensure that I haven't inadvertently deleted necessary docs or artifacts.

Copy link
Contributor

@sandeepnRES sandeepnRES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just one minor comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants