Skip to content
This repository has been archived by the owner on May 13, 2022. It is now read-only.

Cleanup: introduce word256 and remove dependency on tendermint/go-common #499

Conversation

benjaminbollen
Copy link
Contributor

While working on release-0.16, to have the eris-db definitions for Permissions to be a clean import into eris tooling, I removed the lingering dependency on tendermint/go-common; this saw me forced to pull this new type through the EVM and state as well; and finally there was then no need to preserve tendermint/go-common for sanity checks and random numbers for tests.

  • introduces eris-db/word256 for bytes32 and padding and conversion functions

  • introduces eris-db/common/sanity for wrapping PanicSanity and PanicCrisis

  • introduces eris-db/common/random for wrapping around rand and crypto/rand

  • changes imports across eris-db/manager and eris-db/permissions

@silasdavis silasdavis self-requested a review February 16, 2017 12:25
Copy link
Contributor

@silasdavis silasdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great news.

It looks like this is all extracted from go-common, which has no tests. So it doesn't make matters any worse but not adding them so I'm approving.

So I know you know this, but I'm going to say it anyway: this stuff is so unit testable, wtf are the tests?

@benjaminbollen
Copy link
Contributor Author

Yes, I agree, particularly by separating it into a word256 instead of a bigger common bag; it makes it very clear what the unit testing for it should be

@silasdavis silasdavis merged commit 25baef2 into hyperledger-archives:release-0.16 Feb 16, 2017
silasdavis added a commit to silasdavis/burrow that referenced this pull request Mar 9, 2019
…se-0.16-remove-tendermint-common

Cleanup: introduce word256 and remove dependency on tendermint/go-common
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants