Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emptyBlockPeriodSeconds should take validator voting into account #7873

Open
roderik opened this issue Nov 10, 2024 · 1 comment
Open

emptyBlockPeriodSeconds should take validator voting into account #7873

roderik opened this issue Nov 10, 2024 · 1 comment
Assignees
Labels
bug Something isn't working non mainnet (private networks) not related to mainnet features - covers privacy, permissioning, IBFT2, QBFT P3 Medium (ex: JSON-RPC request not working with a specific client library due to loose spec assumtion)

Comments

@roderik
Copy link
Contributor

roderik commented Nov 10, 2024

Steps to Reproduce

  1. Send qbft voting json-rpc in a network producing empty blocks
  2. Validator change goes in effect only after 2 empty blocks with the slower emptyBlockPeriodSeconds

Expected behavior:

After voting, it should build a block to make the change go into effect at the speed of the secondsPerBlock, not emptyBlockPeriodSeconds

Actual behavior:

The node does not consider these votes as transactions, not reverting to the lower block seconds

Frequency: [What percentage of the time does it occur?]

100% reproducable

Logs

Please post relevant logs from Besu (and the consensus client, if running proof of stake) from before and after the issue.

Versions (Add all that apply)

  • Software version: 24.10.0

cc @amsmota

@roderik roderik added the bug Something isn't working label Nov 10, 2024
@pullurib
Copy link
Contributor

please assign it to me

@macfarla macfarla added non mainnet (private networks) not related to mainnet features - covers privacy, permissioning, IBFT2, QBFT P3 Medium (ex: JSON-RPC request not working with a specific client library due to loose spec assumtion) labels Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non mainnet (private networks) not related to mainnet features - covers privacy, permissioning, IBFT2, QBFT P3 Medium (ex: JSON-RPC request not working with a specific client library due to loose spec assumtion)
Projects
None yet
Development

No branches or pull requests

3 participants