Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose runtime values of minGasPrice and minPriorityFee as metrics #6291

Closed
fab-10 opened this issue Dec 13, 2023 · 4 comments
Closed

Expose runtime values of minGasPrice and minPriorityFee as metrics #6291

fab-10 opened this issue Dec 13, 2023 · 4 comments
Labels
enhancement New feature or request mainnet non mainnet (private networks) not related to mainnet features - covers privacy, permissioning, IBFT2, QBFT TeamChupa GH issues worked on by Chupacabara Team

Comments

@fab-10
Copy link
Contributor

fab-10 commented Dec 13, 2023

With #6080 and #6097, is now possible to change the values of the --min-gas-price and --min-priority-fee options at runtime, for this is convenient to expose the runtime values of both options as metrics so they can be tracked and monitored
@non-fungible-nelson non-fungible-nelson added enhancement New feature or request mainnet TeamChupa GH issues worked on by Chupacabara Team non mainnet (private networks) not related to mainnet features - covers privacy, permissioning, IBFT2, QBFT labels Dec 18, 2023
@Brindrajsinh-Chauhan
Copy link
Contributor

@fab-10 Would be happy to work on this if this not something you are actively working on

@fab-10 fab-10 removed their assignment Feb 7, 2024
@fab-10
Copy link
Contributor Author

fab-10 commented Feb 7, 2024

Hi @Brindrajsinh-Chauhan, I am not working on it at the moment, so feel free to work on it.

Merged
@Brindrajsinh-Chauhan
Copy link
Contributor

@fab-10 Opened a PR (mentioned above) for the same, would be grateful to get your reviews/feedback on it.

Thank you

@matthew1001
Copy link
Contributor

It sounds like this can be closed as PR #6587 has now merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request mainnet non mainnet (private networks) not related to mainnet features - covers privacy, permissioning, IBFT2, QBFT TeamChupa GH issues worked on by Chupacabara Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@matthew1001 @non-fungible-nelson @Brindrajsinh-Chauhan @fab-10