Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

besu is failing stPrecompile tests on Berlin #1611

Closed
winsvega opened this issue Nov 25, 2020 · 3 comments
Closed

besu is failing stPrecompile tests on Berlin #1611

winsvega opened this issue Nov 25, 2020 · 3 comments

Comments

@winsvega
Copy link

Besu develop is different to geth develop
Screenshot_20201125-140905
@shemnon
Copy link
Contributor

shemnon commented Nov 25, 2020

Besu has integrated EIP-2565 for the modExp repricing, Were these tests run agains the original gas calculations?

@winsvega
Copy link
Author

Hmm, looks like it does. Let me double check.
ethereum/go-ethereum#21607

@winsvega
Copy link
Author

The change comes together with other eips (2718/2930) in geth. And it cannot be activated separately. Therefore the test was generated without this eip.

Looks like the besu client is right.

@winsvega winsvega mentioned this issue Nov 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shemnon @winsvega