-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve JS Api #103
Comments
I think it will be useful to implement these improvements before openwallet-foundation/credo-ts#1331, as otherwise users will need to care about freeing a lot object handles that most likely will not be useful other than being inputs as some classes like I'll pick these changes up if nobody is working on that yet. |
Yes, mostly. For some few cases the handle clearing by the app will still be needed (for instance the one of the resulting presentation in the example) |
As @genaris has highlighted in # the API for parsing objects could be improved.
currently you have to do the following to load a credential definition:
It would be nice if
load
took a json object instead of a string. We also discussed that e.g.Presentation.create
could just take json objects as input, and do the loading in thePresentation
class so the user doesn't need to care about the object handles etc..I think we should make the API just json objects wherever we can
The text was updated successfully, but these errors were encountered: