-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[documentation] #2113: Document features in Cargo.toml files #2180
[documentation] #2113: Document features in Cargo.toml files #2180
Conversation
f76a2e4
to
31cc2e2
Compare
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #2180 +/- ##
===============================================
+ Coverage 0 76.36% +76.36%
===============================================
Files 0 184 +184
Lines 0 26151 +26151
===============================================
+ Hits 0 19971 +19971
- Misses 0 6180 +6180
Continue to review full report at Codecov.
|
version/Cargo.toml
Outdated
std = ["iroha_macro/std", "parity-scale-codec/std", "thiserror"] | ||
# Derive the version trait, which allows API versioning of transactions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not only transactions but also queries and websocket messages are versioned.
If we describe this, I think we should do in the top of iroha_version
crate
# Derive the version trait, which allows API versioning of transactions | |
# Enable macros for versioning |
To be left to another PR:
- I just realized
iroha_version_derive
contains no derive macros. The crate can be renamed - I wonder why this feature is feature because the macros seem to be essential to the crate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the wording
# Support the included CLI | ||
cli = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question, what use cli
feature will have in the future @appetrosyan ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully it can be factored out and removed. My assumption at the time was to make our current CLI implementation optional. As our experience with roles demonstrated, it's not worth the overhead.
…ml files Signed-off-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: Ekaterina Mekhnetsova [email protected]
Description of the Change
Provide descriptions of features in
Cargo.toml
filesIssue
Closes #2113