Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor]: bump rust version to 1.58. #1822

Closed

Conversation

appetrosyan
Copy link
Contributor

@appetrosyan appetrosyan commented Jan 18, 2022

Signed-off-by: Aleksandr [email protected]

Description of the Change

Bumped the version of rust and satisfied the lints added in 1.58.

Issue

None

Benefits

Update

Possible Drawbacks

None

Usage Examples or Tests [optional]

rustup toolchain update stable && cargo lints clippy --workspace --benches --tests --examples

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Jan 18, 2022
@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #1822 (9a691aa) into iroha2-dev (4161360) will decrease coverage by 0.04%.
The diff coverage is 97.56%.

Impacted file tree graph

@@              Coverage Diff               @@
##           iroha2-dev    #1822      +/-   ##
==============================================
- Coverage       78.31%   78.27%   -0.05%     
==============================================
  Files             148      148              
  Lines           21354    21373      +19     
==============================================
+ Hits            16723    16729       +6     
- Misses           4631     4644      +13     
Impacted Files Coverage Δ
config/src/lib.rs 16.66% <ø> (ø)
config/src/runtime_upgrades.rs 79.31% <ø> (ø)
core/src/wsv.rs 90.22% <ø> (ø)
crypto/src/lib.rs 82.70% <ø> (ø)
crypto/src/multihash.rs 80.16% <ø> (ø)
data_model/src/transaction.rs 64.31% <ø> (ø)
logger/src/telemetry.rs 71.59% <ø> (ø)
version/src/lib.rs 40.74% <ø> (ø)
data_model/src/isi.rs 80.24% <83.33%> (-0.63%) ⬇️
actor/src/lib.rs 89.49% <100.00%> (+0.41%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4161360...9a691aa. Read the comment docs.

@appetrosyan
Copy link
Contributor Author

Updating the CI container at the moment. Should fix the static analysis.

@@ -133,18 +133,21 @@ pub struct KeyGenConfiguration {

impl KeyGenConfiguration {
/// Use seed
#[must_use]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also mark structures as must_use if it makes sense. I think an example is Result

@appetrosyan appetrosyan changed the title [refactor]: bump rust version to 1.58. [refactor]: bump rust version to 1.59. Jan 18, 2022
@appetrosyan appetrosyan changed the title [refactor]: bump rust version to 1.59. [refactor]: bump rust version to 1.58. Jan 18, 2022
@appetrosyan appetrosyan marked this pull request as draft January 18, 2022 10:02
@e-ivkov
Copy link
Contributor

e-ivkov commented Jan 18, 2022

We faced the following issue, preventing from merging this PR for now rust-lang/rust-clippy#8307

@appetrosyan
Copy link
Contributor Author

The issue fix is not merged into rust 1.58.1. Thus it may well be that we will need to skip this version altogether, and wait until 1.59.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants