-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor]: bump rust version to 1.58. #1822
Conversation
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #1822 +/- ##
==============================================
- Coverage 78.31% 78.27% -0.05%
==============================================
Files 148 148
Lines 21354 21373 +19
==============================================
+ Hits 16723 16729 +6
- Misses 4631 4644 +13
Continue to review full report at Codecov.
|
Updating the CI container at the moment. Should fix the static analysis. |
@@ -133,18 +133,21 @@ pub struct KeyGenConfiguration { | |||
|
|||
impl KeyGenConfiguration { | |||
/// Use seed | |||
#[must_use] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also mark structures as must_use
if it makes sense. I think an example is Result
a3aee5c
to
2f3f502
Compare
Signed-off-by: Aleksandr <[email protected]>
2f3f502
to
9a691aa
Compare
We faced the following issue, preventing from merging this PR for now rust-lang/rust-clippy#8307 |
The issue fix is not merged into rust 1.58.1. Thus it may well be that we will need to skip this version altogether, and wait until 1.59. |
Signed-off-by: Aleksandr [email protected]
Description of the Change
Bumped the version of
rust
and satisfied the lints added in 1.58.Issue
None
Benefits
Update
Possible Drawbacks
None
Usage Examples or Tests [optional]
rustup toolchain update stable && cargo lints clippy --workspace --benches --tests --examples