New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change query HTTP endpoint from GET to POST #1384

Closed

e-ivkov opened this issue Aug 30, 2021 · 0 comments · Fixed by #1385

Assignees

Labels

iroha2-dev

Contributor

e-ivkov commented Aug 30, 2021

The change is necessary due to the following:

Many libraries (iOS/Swift standard one in particular) do not allow to submit body in GET requests
It is a popular opinion that submitting body in the GET request is a bad practice - leads to libraries not supporting this.

We need to send body still as we send big SCALE encoded query payloads.

e-ivkov added the iroha2-dev label

e-ivkov added this to the i2 Preview Release 1 milestone

e-ivkov self-assigned this

e-ivkov mentioned this issue

Change query endpoint to POST instead of GET #1385

Merged

e-ivkov linked a pull request

that will close this issue

Change query endpoint to POST instead of GET #1385

Merged

e-ivkov closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment