Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to thiserror #1223

Closed
takemiyamakoto opened this issue Jul 15, 2021 · 1 comment
Closed

Migrate to thiserror #1223

takemiyamakoto opened this issue Jul 15, 2021 · 1 comment
Labels
Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@takemiyamakoto
Copy link

This crate is already used in our dependency tree, but we reimplement some of its functionality, it is better to remove our code for this and use this crate features instead.
@takemiyamakoto takemiyamakoto added iroha2-dev The re-implementation of a BFT hyperledger in RUST Enhancement New feature or request labels Jul 15, 2021
@e-ivkov
Copy link
Contributor

e-ivkov commented Sep 8, 2021

Our custom functionality is implemented in https://github.com/hyperledger/iroha/blob/iroha2-dev/iroha_error/iroha_error_macro/src/lib.rs

@KalitaAlexey KalitaAlexey mentioned this issue Sep 10, 2021
Merged
@e-ivkov e-ivkov closed this as completed Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@e-ivkov @takemiyamakoto