This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Make CreateAccount cmd validation stronger #1966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 18, 2018 15:48
Signed-off-by: Igor Egorov <[email protected]>
It should not be possible to create an account in a domain which default role has some permissions that does not have a creator of a transaction. Signed-off-by: Igor Egorov <[email protected]>
igor-egorov
added
needs-review
Akvinikym
suggested changes
Dec 19, 2018
kamilsa
approved these changes
Dec 20, 2018
l4l
added
needs-correction
Signed-off-by: Igor Egorov <[email protected]>
Akvinikym
approved these changes
Dec 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Igor Egorov [email protected]
Description of the Change
Validation of CreateAccount command will respect a set of permissions of transaction creator.
It would not be possible to create an account in a domain which default role contain some permissions that are missing in transaction creator's permissions set.
In short: transaction creator should have all the permissions of default role of a domain where new account will be created.
Benefits
Permissions escalation is not possible via creating accounts in more priveleged domains.
Possible Drawbacks
None ?
Usage Examples or Tests
create_account_test