Skip to content
This repository has been archived by the owner on Apr 17, 2019. It is now read-only.

Add color diagnostics #1515

Merged
merged 2 commits into from
Jul 2, 2018
Merged

Add color diagnostics #1515

merged 2 commits into from
Jul 2, 2018

Conversation

l4l
Copy link
Contributor

@l4l l4l commented Jun 29, 2018

Description of the Change

Enable colors in builds (works for CI + ninja and maybe somewhere else)

Benefits

Color!

Possible Drawbacks

None

@l4l l4l added needs-review pr awaits review from maintainers infrastructure anything related to continious integration, building infrastructure, or cmake labels Jun 29, 2018
@l4l l4l requested review from bakhtin and lebdron June 29, 2018 12:14
@l4l l4l force-pushed the feature/color_diagnostic branch from be98033 to da88c9c Compare June 29, 2018 13:35
Copy link
Contributor

@bakhtin bakhtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sorabot
Copy link

sorabot commented Jun 29, 2018

@l4l l4l force-pushed the feature/color_diagnostic branch from 01eae00 to f5ed400 Compare June 29, 2018 19:59
@sorabot
Copy link

sorabot commented Jun 29, 2018

Copy link
Contributor

@lebdron lebdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow it also works for clang and appleclang, even if it does not look like a documented feature for these compilers.

@l4l l4l merged commit 6e79160 into develop Jul 2, 2018
@l4l l4l deleted the feature/color_diagnostic branch July 2, 2018 18:59
@l4l l4l removed the needs-review pr awaits review from maintainers label Jul 2, 2018
l4l added a commit that referenced this pull request Jul 25, 2018
l4l added a commit that referenced this pull request Jul 25, 2018
l4l added a commit that referenced this pull request Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
infrastructure anything related to continious integration, building infrastructure, or cmake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants