This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l4l
added
needs-review
pr awaits review from maintainers
infrastructure
anything related to continious integration, building infrastructure, or cmake
labels
Jun 29, 2018
Signed-off-by: Kitsu <[email protected]>
l4l
force-pushed
the
feature/color_diagnostic
branch
from
June 29, 2018 13:35
be98033
to
da88c9c
Compare
bakhtin
approved these changes
Jun 29, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@lebdron @bakhtin commit 01eae00 build status: SUCCESS. build URL: https://jenkins.soramitsu.co.jp/job/iroha/job/iroha-hyperledger/job/PR-1515/4/ |
Signed-off-by: Kitsu <[email protected]>
l4l
force-pushed
the
feature/color_diagnostic
branch
from
June 29, 2018 19:59
01eae00
to
f5ed400
Compare
@lebdron @bakhtin commit f5ed400 build status: SUCCESS. build URL: https://jenkins.soramitsu.co.jp/job/iroha/job/iroha-hyperledger/job/PR-1515/5/ |
lebdron
approved these changes
Jun 30, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow it also works for clang and appleclang, even if it does not look like a documented feature for these compilers.
l4l
added a commit
that referenced
this pull request
Jul 25, 2018
Signed-off-by: Kitsu <[email protected]>
l4l
added a commit
that referenced
this pull request
Jul 25, 2018
Signed-off-by: Kitsu <[email protected]>
l4l
added a commit
that referenced
this pull request
Jul 25, 2018
Signed-off-by: Kitsu <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Enable colors in builds (works for CI + ninja and maybe somewhere else)
Benefits
Color!
Possible Drawbacks
None