This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Proper database drop for storage #1406
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Storage::init - Add StorageImpl::cleanupTables - Add logic for database drop in StorageImpl::dropStorage - Refactor ametsuchi test a bit Signed-off-by: Kitsu <[email protected]>
l4l
added
needs-review
l4l
requested review from
kamilsa,
lebdron and
igor-egorov
and removed request for
kamilsa
igor-egorov
suggested changes
Jun 2, 2018
Signed-off-by: Kitsu <[email protected]>
l4l
added
candidate-for-closing
and removed
needs-review
- Do not catch exception for dropStorage - Add reset method for Storage iface, use cleanupTables in StorageImpl for that - Use proper methods, where its applicable Signed-off-by: Kitsu <[email protected]>
|
@l4l why is this PR pending? |
|
@neewy it does not work with current structures of connections. Introducing SOCI will probably help to get this done. |
|
I close pr, but please do not delete the branch. It might be reused upon required fixes are done |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Benefits
Now postgres is not polluted by the numerous databases created after tests
Possible Drawbacks
None?
Usage Examples or Tests
Try ametsuchi_test or any integration test, after the test is finished there should be no new databases.