Skip to content
This repository has been archived by the owner on Apr 17, 2019. It is now read-only.

Add feature for custom genesis block gen #1168

Merged
merged 2 commits into from
Apr 16, 2018
Merged

Add feature for custom genesis block gen #1168

merged 2 commits into from
Apr 16, 2018

Conversation

l4l
Copy link
Contributor

@l4l l4l commented Mar 31, 2018

Description of the Change

Allow transaction loading for genesis block generation in cli. I know it is going to be rewritten but that small fix enable that vial feature.

Benefits

Configuration of the genesis block

Usage Examples or Tests [optional]

  1. Generate transaction in json
  2. Launch iroha-cli --genesis_block --genesis_transaction <your_file>

@l4l l4l added needs-review pr awaits review from maintainers refactoring internal stuff, that are changed/removed that doesn't affect client code cli command line interface labels Mar 31, 2018
@l4l l4l requested review from Alexey-N-Chernyshov and grimadas and removed request for Alexey-N-Chernyshov April 15, 2018 18:27
logger->error("--peers_address is empty");
return EXIT_FAILURE;
iroha::model::Transaction transaction;
if (FLAGS_genesis_transaction == "") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe empty()

@@ -55,6 +57,9 @@ DEFINE_string(json_query, "", "Query in json format");
DEFINE_bool(genesis_block,
false,
"Generate genesis block for new Iroha network");
DEFINE_string(genesis_transaction,
"",
"File with transaction in json format for the genesis");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the genesis block

Signed-off-by: Kitsu <[email protected]>
@l4l l4l merged commit 5c4169f into develop Apr 16, 2018
@l4l l4l deleted the feature/genesis_txes branch April 16, 2018 12:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cli command line interface needs-review pr awaits review from maintainers refactoring internal stuff, that are changed/removed that doesn't affect client code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants