Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ledger-browser): handle ERC721 token metadata #3552

Open
outSH opened this issue Sep 27, 2024 · 0 comments
Open

feat(ledger-browser): handle ERC721 token metadata #3552

outSH opened this issue Sep 27, 2024 · 0 comments
Labels
enhancement New feature or request Epic ethereum Issues related to ethereum connector and peristence plugin good-first-issue-300-advanced ledger-browser Issues related to cacti-ledger-browser package P4 Priority 4: Low

Comments

@outSH
Copy link
Contributor

outSH commented Sep 27, 2024

Is your feature request related to a problem? Please describe.

Ethereum App on ledger browser should display information stored in ERC721 token metadata file (if available).

Describe the solution you'd like

This is a multi-step issue that require changes in 2 components (sub tasks will be created if issue is assigned).

  • Modify cactus-plugin-persistence-ethereum to get metadata URL from tokenURI() and parse the JSON file. It should handle connection errors, invalid and non-conformant files. Fetched data (name, description, image-url) should be pushed to the database. Scenario and error cases should be covered by an automatic test.
  • Modify ledger-browser Ethereum Browser App to display new data on ERC721 view in Accounts tab.

Additional context

@outSH outSH added enhancement New feature or request Epic good-first-issue-300-advanced ledger-browser Issues related to cacti-ledger-browser package P4 Priority 4: Low ethereum Issues related to ethereum connector and peristence plugin labels Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Epic ethereum Issues related to ethereum connector and peristence plugin good-first-issue-300-advanced ledger-browser Issues related to cacti-ledger-browser package P4 Priority 4: Low
Projects
None yet
Development

No branches or pull requests

1 participant