Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(codegen): fix cmd-api-server .jar download race condition - again #3015

Closed
petermetz opened this issue Feb 7, 2024 · 1 comment
Closed
Assignees
Labels
bug Something isn't working dependencies Pull requests that update a dependency file Developer_Experience Flaky-Test-Automation Issues related to test stability (which is a long running issue that can never fully be solved) P3 Priority 3: Medium
Milestone

Comments

@petermetz
Copy link
Contributor

Description

The .jar download mechanism and the warm-up script has gotten us far but now the cmd-api-server package's interfering with it. Most likely because that package declares the open api generator as a dev dependency on it's own and that is causing it to not use the same installation of the same package from the root node_modules and that's why it ends up re-downloading the .jar file. This is just a theory for now but an initial glance at the log file (attached below) seems to support this theory as does the fact that the past 3 times when I observed this crash on the CI it was always the cmd-api-server package causing the problem instead of it being randomly distributed among the packages like it was before.

2024-02-07T15-54-14.0195638Z-cmd-api-server-codegen-race-condition.ci.test.crash.log

Solution ideas:

  1. Use the --top-level flag of the yarn CLI to force the usage of the root level node_modules directory's .jar file
  2. Refactor the code so that the warm-up script copies the .jar file to all the locations where it's needed (e.g. all the package directories node_modules subfolders.)

Acceptance Criteria

  1. Race condition in the codegen script is eliminated.
  2. No complicated logic has been introduced to fix it.
@petermetz petermetz self-assigned this Feb 7, 2024
@petermetz petermetz added the P3 Priority 3: Medium label Feb 7, 2024
@petermetz petermetz added this to the v2.1.0 milestone Feb 7, 2024
@petermetz petermetz added bug Something isn't working dependencies Pull requests that update a dependency file Developer_Experience Flaky-Test-Automation Issues related to test stability (which is a long running issue that can never fully be solved) labels Feb 7, 2024
@petermetz petermetz removed their assignment Feb 7, 2024
@ruzell22
Copy link
Contributor

fixed by: #3289 and also tested 10 times while also limiting RAM to 7GB and vCPU cores to 2 and is running successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file Developer_Experience Flaky-Test-Automation Issues related to test stability (which is a long running issue that can never fully be solved) P3 Priority 3: Medium
Projects
None yet
Development

No branches or pull requests

2 participants